forked from mileperhour/localtuya-homeassistant
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eco mode custom format #1929
Open
AlePerla
wants to merge
12
commits into
rospogrigio:master
Choose a base branch
from
AlePerla:eco_mode_custom_format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Eco mode custom format #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et always added if there are presets (to fix values display during config flow) modified: custom_components/localtuya/__init__.py * no dots in logged lines modified: custom_components/localtuya/climate.py + function to convert value based on selected format * add No preset always if there are other presets modified: custom_components/localtuya/const.py + constants for format and none value modified: custom_components/localtuya/manifest.json * version * codeowners modified: custom_components/localtuya/strings.json modified: custom_components/localtuya/translations/en.json modified: custom_components/localtuya/translations/it.json modified: custom_components/localtuya/translations/pt-BR.json + translations (to be fixed pt-BR)
…et always added if there are presets (to fix values display during config flow) modified: custom_components/localtuya/__init__.py * no dots in logged lines modified: custom_components/localtuya/climate.py + function to convert value based on selected format * add No preset always if there are other presets modified: custom_components/localtuya/const.py + constants for format and none value modified: custom_components/localtuya/manifest.json * version * codeowners modified: custom_components/localtuya/strings.json modified: custom_components/localtuya/translations/en.json modified: custom_components/localtuya/translations/it.json modified: custom_components/localtuya/translations/pt-BR.json + translations (to be fixed pt-BR)
* set of none without return was sending it dobled and with wrong value
* using custom values only when set
…com/AlePerla/localtuya into none_preset_always_value_conversion
None preset always present and custom value conversion
…_conversion Revert "None preset always present and custom value conversion"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issue I experimented with a Tuya thermal regulator using Smart Life app (#1884).
Basically inside the
localtuya/custom_components/localtuya/climate.py
Line 330 in 5f2c027
So, I added a check and forced insertion if there are some presets but PRESET_NONE is not listed.
Then, in
localtuya/custom_components/localtuya/climate.py
Line 431 in 5f2c027
localtuya/custom_components/localtuya/climate.py
Line 471 in 5f2c027
Therefore, I added a new configuration to force a specific format.
These solved my problem.
Hope it helps