Correct solaris libc definitions: #516
Conversation
* pthread_t is defined as uint_t, so must be c_uint, not uintptr_t, just as pthread_key_t is already defined * fd_set is defined as long, so must be i32/i64 based on target_pointer_width; this also fixes an indirect endianness issue encountered on sparc * FD_SETSIZE should be defined as 65536 when target_pointer_width = 64 Fixes rust-lang#515
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit 8304e06 has been approved by |
Correct solaris libc definitions: * pthread_t is defined as uint_t, so must be c_uint, not uintptr_t, just as pthread_key_t is already defined * fd_set is defined as long, so must be i32/i64 based on target_pointer_width; this also fixes an indirect endianness issue encountered on sparc * FD_SETSIZE should be defined as 65536 when target_pointer_width = 64 Fixes #515
|
💔 Test failed - status-travis |
|
I don't understand the test failures; I ran |
|
Oh the tidy script in this repo is different, it's |
|
This is a trap for new contributors; any chance of either updating the contributing document so that it points out that submodules have different contribution guidelines? Also, it seems unfortunate that the same rules for the main rust repo don't apply to submodules; a unified contribution process would simplify things for new contributors. I will try style.rs and see what's wrong, thanks. |
|
@bors: r+ Oh right yeah the contributing document is intended for rust-lang/rust and basically just got copied over here unfotunately :( |
|
📌 Commit 86b0cab has been approved by |
Correct solaris libc definitions: * pthread_t is defined as uint_t, so must be c_uint, not uintptr_t, just as pthread_key_t is already defined * fd_set is defined as long, so must be i32/i64 based on target_pointer_width; this also fixes an indirect endianness issue encountered on sparc * FD_SETSIZE should be defined as 65536 when target_pointer_width = 64 Fixes #515
|
☀️ Test successful - status-appveyor, status-travis |
Auto merge of rust-lang#516 - binarycrusader:master, r=alexcrichton
as pthread_key_t is already defined
target_pointer_width; this also fixes an indirect endianness issue
encountered on sparc
Fixes #515