Rollup of 9 pull requests #141066
Merged
Rollup of 9 pull requests #141066
+461
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2 commands do the same thing. Also, follow style used elsewhere in the guide.
Rustc pull update
Fix minor typo in serialization.md
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
…ounds on generic function Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Align advice to discourage issue-number-only names
Fix minor typo in installation.md
Fix minor typo in rustdoc-internals.md
add rdg push git config entry for git protocol pushers
This made it look the the topic was covered in the chapter just before the current one.
They are internal tools.
Migrate to modern datetime API # PR Summary This small PR resolves the `datetime` library warnings: ```python DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). or datetime.datetime.utcnow() ``` Note that `.replace(tzinfo=None)` allows to keep the original behavior where the time appears as a naive UTC timestamp (i.e., without any timezone offset). Comparision: ```python # With .utcnow() or .now(datetime.timezone.utc).replace(tzinfo=None) Time,Idle 2025-05-14T15:40:25.013414,98.73417721518987 # With .now(datetime.timezone.utc) Time,Idle 2025-05-14T15:40:25.013414+00:00,98.73417721518987 ```
…pinfo_windows, r=joboet Implement methods to set STARTUPINFO flags for Command API on Windows Implements rust-lang#141010
rustc-dev-guide subtree update r? ``@ghost``
rustbot
added
A-rustc-dev-guide
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5ce27f5 with merge c79bbfab78dcb0a72aa3b2bc35c00334b58bfe2e... |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 7e19eef048 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7e19eef (parent) -> c79bbfa (this PR) Test differencesShow 529 test diffsStage 1
Stage 2
(and 405 additional test diffs) Additionally, 24 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c79bbfab78dcb0a72aa3b2bc35c00334b58bfe2e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced May 16, 2025
|
Finished benchmarking commit (c79bbfa): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 4.5%, secondary 1.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 4.9%, secondary -3.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 772.011s -> 772.547s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TryIntooverTryFromwhen specifying traits bounds on generic function #140791 (std: explain preferTryIntooverTryFromwhen specifying traits bounds on generic function)stableattribute from wasi fs (read_exact|write_all)_at #140910 (Removestableattribute from wasi fs (read_exact|write_all)_at)-Clink-self-containedand-Zlinker-features#140997 (Add negative test coverage for-Clink-self-containedand-Zlinker-features)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup