Rollup of 14 pull requests #141067
Open
Rollup of 14 pull requests #141067
+1,302
−368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2 commands do the same thing. Also, follow style used elsewhere in the guide.
Rustc pull update
Fix minor typo in serialization.md
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
…ounds on generic function Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
Align advice to discourage issue-number-only names
Fix minor typo in installation.md
Fix minor typo in rustdoc-internals.md
add rdg push git config entry for git protocol pushers
This made it look the the topic was covered in the chapter just before the current one.
They are internal tools.
This requires a fix to the subnormal test to cap the maximum allowed value within the maximum mantissa.
On Fuchsia, we have an internal Gerrit mirrors of the rust repositories to avoid excess load on the public github servers. Since rust uses submodules, we need to then use git's `url.<base>.insteadOf` to point our checkouts at our mirrors. We'd prefer to be able to point all repositories under `https://github.com/rust-lang` to `https://rust.googlesource.com/rust-lang`, but unfortunately it seems that when Rust mirrored Enzyme, the repository name was lower cased to `https://github.com/rust-lang/enzyme`, but kept the name capitalized in the .gitmodules file. This didn't cause a problem for Github, which seems to handle repository names in a case insensitive way, Gerrit is case sensitive, so we can't use a glob rule. Instead we have to setup `insteadOf` rules for each repository. This renames the URL to match the case of the repository name, which should avoid the issue.
One could be tempted to replace the "then" `hir::Expr` with kind `hir::ExprKind::Block` by a `hir::Block`. Explain why this would not be a good idea.
…Simulacrum Add `f16` formatting and parsing Use the same algorithms as for `f32` and `f64` to implement `f16` parsing and printing. try-job: aarch64-gnu try-job: dist-s390x-linux try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function Fixes rust-lang#140761 This PR keeps the explanations of `Into` and `From` consistent and adds explanations for `TryInto` and `TryFrom`. r? libs
move (or remove) some impl Trait tests Probably not actually worth the effort, so I am stopping here 😅
…tabilization, r=joboet Remove `stable` attribute from wasi fs (read_exact|write_all)_at The docs for [`std::os::wasi::fs::FileExt::read_exact_at`](https://doc.rust-lang.org/1.86.0/std/os/wasi/fs/trait.FileExt.html#method.read_exact_at) and [`std::os::wasi::fs::FileExt::write_all_at`](https://doc.rust-lang.org/1.86.0/std/os/wasi/fs/trait.FileExt.html#method.write_all_at) show the methods to be stable since v1.33, which is not correct and was a mistake made when the methods were added in (rust-lang#74076 (review)). The reviewer seemed to think this was an insta-stabilization, but the entire file is marked as unstable so that was not right. The stabilization version would also have been wrong either way.
fix doc for UnixStream Doc example was using `UdpSocket` instead of `UnixStream`.
…, r=lqd Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features` Noticed while reviewing stabilization rust-lang#140525 that we don't have any negative test coverage for these flags. Feel free to cherry-pick these tests into the stabilization PR, or we can land these before separately. r? ``@lqd``
…ler-errors Improve ternary operator recovery This - Improves the span of the error to not point at the next token - Where possible, we use the span of the condition to further improve the span of the error to include the cond, and suggest a maybe-incorrect fix Currently this works on free expressions, not let statements; some more refactoring would be needed to pass the span down, which I'm not sure is worth doing. ### Old  ### New 
Migrate to modern datetime API # PR Summary This small PR resolves the `datetime` library warnings: ```python DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). or datetime.datetime.utcnow() ``` Note that `.replace(tzinfo=None)` allows to keep the original behavior where the time appears as a naive UTC timestamp (i.e., without any timezone offset). Comparision: ```python # With .utcnow() or .now(datetime.timezone.utc).replace(tzinfo=None) Time,Idle 2025-05-14T15:40:25.013414,98.73417721518987 # With .now(datetime.timezone.utc) Time,Idle 2025-05-14T15:40:25.013414+00:00,98.73417721518987 ```
…pinfo_windows, r=joboet Implement methods to set STARTUPINFO flags for Command API on Windows Implements rust-lang#141010
rustc-dev-guide subtree update r? ```@ghost```
…ncy-fix, r=oli-obk Async drop fix for dropee from another crate (rust-lang#140858) Fixes rust-lang#140858. For `AsyncDestructor` impl def id was wrongly kept as a LocalDefId, which causes crash when dropee is declared in another crate. Also, potential problem found: when user crate drops type with async drop in dependency crate, and user crate doesn't enable `feature(async_drop)`, then sync drop version will be used. Is it a problem? Do we need some notification about such situations?
ci: split the dist-ohos job try-job: `dist-ohos-*`
Lowercase git url for rust-lang/enzyme.git On Fuchsia, we have an internal Gerrit mirrors of the rust repositories to avoid excess load on the public github servers. Since rust uses submodules, we need to then use git's `url.<base>.insteadOf` to point our checkouts at our mirrors. We'd prefer to be able to point all repositories under `https://github.com/rust-lang` to `https://rust.googlesource.com/rust-lang`, but unfortunately it seems that when Rust mirrored Enzyme, the repository name was lower cased to `https://github.com/rust-lang/enzyme`, but kept the name capitalized in the .gitmodules file. This didn't cause a problem for Github, which seems to handle repository names in a case insensitive way, Gerrit is case sensitive, so we can't use a glob rule. Instead we have to setup `insteadOf` rules for each repository. This renames the URL to match the case of the repository name, which should avoid the issue.
…=compiler-errors HIR: explain in comment why `ExprKind::If` "then" is an `Expr` One could be tempted to replace the "then" `hir::Expr` with kind `hir::ExprKind::Block` by a `hir::Block`. Explain why this would not be a good idea. I've been there. r? `@compiler-errors`
rustbot
added
A-rustc-dev-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
f16formatting and parsing #127013 (Addf16formatting and parsing)TryIntooverTryFromwhen specifying traits bounds on generic function #140791 (std: explain preferTryIntooverTryFromwhen specifying traits bounds on generic function)stableattribute from wasi fs (read_exact|write_all)_at #140910 (Removestableattribute from wasi fs (read_exact|write_all)_at)-Clink-self-containedand-Zlinker-features#140997 (Add negative test coverage for-Clink-self-containedand-Zlinker-features)ExprKind::If"then" is anExpr#141059 (HIR: explain in comment whyExprKind::If"then" is anExpr)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup