Link std::process::Output to Command and Child #45113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! We’ll periodically check in on it to make sure that @steveklabnik or someone else from the team reviews it soon. |
carols10cents
added
the
S-waiting-on-review
src/libstd/process.rs
Outdated
| @@ -701,7 +701,14 @@ impl AsInnerMut<imp::Command> for Command { | |||
| fn as_inner_mut(&mut self) -> &mut imp::Command { &mut self.inner } | |||
| } | |||
|
|
|||
| /// The output of a finished process. | |||
| /// The output of a finished process. This is returned in a Result by | |||
There was a problem hiding this comment.
Could you put some newlines between the first and second sentences here? The first sentence operates as a summary, so it's helpful to add space.
/// The output of a finished process.
///
/// This is returned in a Result...
There was a problem hiding this comment.
Done. I think that does look neater :)
|
@bors r=steveklabnik rollup |
|
📌 Commit 8c4a68d has been approved by |
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 14, 2017
…labnik Link std::process::Output to Command and Child As per rust-lang#29370
bors
added a commit
that referenced
this pull request
Oct 14, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 15, 2017
…labnik Link std::process::Output to Command and Child As per rust-lang#29370
bors
added a commit
that referenced
this pull request
Oct 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #29370