Fix TcpStream::connect_timeout on linux #45269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
added
beta-nominated
sfackler
force-pushed
the
connect-timeout-fix
branch
from
53fedf2 to
2bd5238
Compare
kennytm
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 2bd5238 has been approved by |
alexcrichton
added
the
beta-accepted
kennytm
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 14, 2017
…xcrichton Fix TcpStream::connect_timeout on linux Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closes rust-lang#45265. r? @alexcrichton
Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closes rust-lang#45265.
sfackler
force-pushed
the
connect-timeout-fix
branch
from
2bd5238 to
cab99a3
Compare
|
@bors r=alexcrichton |
|
📌 Commit cab99a3 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 14, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 15, 2017
…xcrichton Fix TcpStream::connect_timeout on linux Linux appears to set POLLOUT when a conection's refused, which is pretty weird. Invert the check to look for an error explicitly. Also add an explict test for this case. Closes rust-lang#45265. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Oct 15, 2017
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux appears to set POLLOUT when a conection's refused, which is pretty
weird. Invert the check to look for an error explicitly. Also add an
explict test for this case.
Closes #45265.
r? @alexcrichton