Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of $this binding to $app in route group section #328

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Remove mentions of $this binding to $app in route group section #328

merged 1 commit into from
Feb 20, 2019

Conversation

mbohal
Copy link
Contributor

@mbohal mbohal commented Jan 10, 2019

Related to slimphp/Slim#2560

@akrabat akrabat added the Slim 4 Required for Slim 4 release label Jan 23, 2019
l0gicgate
l0gicgate approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@l0gicgate l0gicgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved, merging. Thank you for your contribution.

@l0gicgate l0gicgate merged commit ee4a745 into slimphp:gh-pages-4.x Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
Slim 4 Required for Slim 4 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbohal @l0gicgate @akrabat