Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove binding of $this to group() #2560

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Remove binding of $this to group() #2560

merged 1 commit into from
Jan 23, 2019

Conversation

vaga
Copy link
Contributor

@vaga vaga commented Jan 4, 2019

It's my first contribution. 🎉

Closes #2559

@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 97.397% when pulling b755a37 on vaga:remove-app-binding-in-route-group into bcf7df5 on slimphp:4.x.

akrabat
akrabat requested changes Jan 4, 2019
View reviewed changes
Copy link
Member

@akrabat akrabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick on a test name.

Also, please update the CHANGELOG

@vaga vaga force-pushed the remove-app-binding-in-route-group branch from 9565d82 to f62f5de Compare January 4, 2019 10:03
@vaga vaga force-pushed the remove-app-binding-in-route-group branch from f62f5de to b755a37 Compare January 4, 2019 10:06
@akrabat akrabat added this to the 4.0 milestone Jan 4, 2019
@mbohal
Copy link

mbohal commented Jan 5, 2019

@akrabat Should I update the https://github.com/slimphp/Slim-Website/tree/gh-pages-4.x to reflect this change?
I'm not sure what is going to happen with the docs when Slim 4 gets released and I do not want to introduce any conflicts.

@akrabat
Copy link
Member

akrabat commented Jan 5, 2019

@mbohal Raise a PR against that branch please.

@mbohal mbohal mentioned this pull request Jan 10, 2019
Merged
@akrabat akrabat added the Slim 4 label Jan 15, 2019
@akrabat akrabat merged commit b755a37 into slimphp:4.x Jan 23, 2019
@akrabat
Copy link
Member

akrabat commented Jan 23, 2019

Thanks @vaga !

@l0gicgate l0gicgate mentioned this pull request Feb 3, 2019
Closed
@l0gicgate l0gicgate mentioned this pull request Apr 25, 2019
Merged
@l0gicgate l0gicgate mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrabat akrabat akrabat requested changes

Assignees
No one assigned
Labels
Slim 4
Projects
None yet
Milestone
4.0.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@vaga @coveralls @mbohal @akrabat