Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

fix problem with matches in ledger-tool #25482

Merged
merged 1 commit into from
May 23, 2022

Conversation

KirillLykov
Copy link
Contributor

@KirillLykov KirillLykov commented May 23, 2022

Problem

It looks like there is a typo matches (arguments do not exist for Command but indeed for SubCommand).

Summary of Changes

Renamed to arg_matches

Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!
lgtm

@jeffwashington
Copy link
Contributor

why is there even a matches??? can we drop it or otherwise get rid of it? It has been on my mental list to consolidate the args that we use between this and validator...

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #25482 (e1f1c04) into master (f9f6b94) will increase coverage by 0.0%.
The diff coverage is 72.1%.

@@            Coverage Diff            @@
##           master   #25482     +/-   ##
=========================================
  Coverage    82.0%    82.0%             
=========================================
  Files         655      620     -35     
  Lines      171822   170107   -1715     
  Branches      335        0    -335     
=========================================
- Hits       140972   139644   -1328     
+ Misses      30734    30463    -271     
+ Partials      116        0    -116     

@jeffwashington jeffwashington merged commit 2cb500a into solana-labs:master May 23, 2022
@KirillLykov
Copy link
Contributor Author

why is there even a matches??? can we drop it or otherwise get rid of it? It has been on my mental list to consolidate the args that we use between this and validator...

It looks like this particular tool needs more love but due to size of code base it might be a week of work. I wanted to update clap to v3 for this tool PR#24594 and that's how I found this problem -- because in clap-v3 calling is_present(arg) for invalid arg leads to panic.

jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants