This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clap3 update: cli #24594
Closed
Clap3 update: cli #24594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillLykov
force-pushed
the
clap3-upd-cli
branch
from
593e379 to
122eed0
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
stale
bot
removed
the
stale
KirillLykov
force-pushed
the
clap3-upd-cli
branch
3 times, most recently
from
134ed61 to
bd1db97
Compare
KirillLykov
force-pushed
the
clap3-upd-cli
branch
5 times, most recently
from
e018f34 to
81daa4c
Compare
KirillLykov
force-pushed
the
clap3-upd-cli
branch
from
81daa4c to
3b3a268
Compare
KirillLykov
force-pushed
the
clap3-upd-cli
branch
from
3b3a268 to
f1754aa
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update clap to v3 for cli. It depends on
faucet,client,cli-outputwhich are also updated.Most of the changes are quite mechanical, but some of the require more attention.
The problem is that the behavior of
ArgsMatchmethod changed: before they returnedfalse/Noneeven in case if argument is not valid argument.It means that we could write helper functions which don't care about existence of particular argument for particular
ArgsMatch.New behavior is panic in case of invalid argument.
These changes requiring more attention are in separate commits:
Problem with signer
The most elaborated problem is solved in the last commit.
For
programsigneris not a valid argument. But it is requested here keypair.rs#L804.Basically, if we have program and use option
SignerSourceKind::Pubkey, it always results in error.The call on program side happens in program.rs#L461 which picks always
elsebranch for the aforementioned case withPubkey.The solution presented in latest commit is not perfect because it makes public some structures which were private before, but it solves the problem and passes all the tests.
Summary of Changes