-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update clap to v3.1.5 for all the repository #23557
Comments
Problem with (2):
Action items:
|
Vim commands to update some clap calls:
|
Hey have you considered how to handle the helper functions in the clap-utils crate? Examples include One possible approach is to create a |
By downstream users, do you mean those mentioned in With clap-utils it is hard by itself to do the upgrade because many other tools within our repo depends on it and some clap's API changes are very particular. It mean that it might be a rather big PR. Having two versions of clap in one repo is probably possible but I found it difficult due to usage of attributes. Haven't figured out yet how to overcome these difficulties. |
That's a start but there are other cli users of |
To verify that I understood it correctly:
On the operational side I like this idea because this will also allow to have smaller PRs |
This PR which migrates the heaviest part of the code base was automatically closed: #24594 (comment) |
clap v2.34.0 clap v3.2.22 |
Sorry, but I don't quite understand what do you want to say by this message |
I wanted to point out that there still clap v2 dependencies which leads to several clap versions in the dependency tree if one relies on those Solana packages. |
@gitmalong that's a known thing, migration from clap v2 to v3 turned out to be too risky and was postponed |
Check: can we avoid panicking by switching to |
I think it is still active, @samkim-crypto is doing this migration |
This repository is no longer in use. Please re-open this issue in the agave repo: https://github.com/anza-xyz/agave |
Problem
Most of the targets use clap v2.33, we want to upgrade to v3.1.5
Proposed Solution
Prepare several PRs to address the problem:
The text was updated successfully, but these errors were encountered: