-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add clap-v3-utils #24096
Add clap-v3-utils #24096
Conversation
03849ad
to
3aeb2ab
Compare
3aeb2ab
to
e326864
Compare
I assume the functionality is all the same so I won't bother reviewing this PR at that level. I do want to bikeshed the name of the crate though. I feel |
I agree, might be easier to understand the idea behind crate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once CI is green!
55e33d3
to
d833011
Compare
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
Problem
Part of the migration to clap v3.
As discussed in this issue , we introduce
clap-utils-v3
component which will coexist withclap-utils
(uses clap v 2.33) for some time.Summary of Changes
Introduces a new library which contains exactly the same functionality as an old one
clap-utils
but uses clap-v3.