This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add clap-v3-utils #24096
Merged
Add clap-v3-utils #24096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2022
KirillLykov
force-pushed
the
add_clap_utils_v3
branch
2 times, most recently
from
03849ad to
3aeb2ab
Compare
KirillLykov
force-pushed
the
add_clap_utils_v3
branch
from
3aeb2ab to
e326864
Compare
|
I assume the functionality is all the same so I won't bother reviewing this PR at that level. I do want to bikeshed the name of the crate though. I feel |
I agree, might be easier to understand the idea behind crate |
KirillLykov
force-pushed
the
add_clap_utils_v3
branch
from
55e33d3 to
d833011
Compare
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
* Add clap-utils-v3 * update Cargo.lock * address PR comment: rename crate * address PR comment: rename to clap-v3-utils * update dep version * fix clippy errors * update Cargo.lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of the migration to clap v3.
As discussed in this issue , we introduce
clap-utils-v3component which will coexist withclap-utils(uses clap v 2.33) for some time.Summary of Changes
Introduces a new library which contains exactly the same functionality as an old one
clap-utilsbut uses clap-v3.