Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add clap-v3-utils #24096

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Conversation

KirillLykov
Copy link
Contributor

Problem

Part of the migration to clap v3.
As discussed in this issue , we introduce clap-utils-v3 component which will coexist with clap-utils (uses clap v 2.33) for some time.

Summary of Changes

Introduces a new library which contains exactly the same functionality as an old one clap-utils but uses clap-v3.

@mvines
Copy link
Contributor

mvines commented Apr 5, 2022

I assume the functionality is all the same so I won't bother reviewing this PR at that level. I do want to bikeshed the name of the crate though. I feel clap-v3-utils is slightly better than clap-utils-v3 because this crate provides solana utils for clap v3 and is not the third version of the solana clap utils.

@KirillLykov
Copy link
Contributor Author

KirillLykov commented Apr 5, 2022

I assume the functionality is all the same so I won't bother reviewing this PR at that level. I do want to bikeshed the name of the crate though. I feel clap-v3-utils is slightly better than clap-utils-v3 because this crate provides solana utils for clap v3 and is not the third version of the solana clap utils.

I agree, might be easier to understand the idea behind crate clap-v3-utils. Done.

@KirillLykov KirillLykov self-assigned this Apr 5, 2022
@KirillLykov KirillLykov changed the title Add clap-utils-v3 Add clap-v3-utils Apr 5, 2022
mvines
mvines previously approved these changes Apr 14, 2022
Copy link
Contributor

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI is green!

@mergify mergify bot dismissed mvines’s stale review April 16, 2022 11:20

Pull request has been modified.

@KirillLykov KirillLykov merged commit 76c80d9 into solana-labs:master Apr 19, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
* Add clap-utils-v3

* update Cargo.lock

* address PR comment: rename crate

* address PR comment: rename to clap-v3-utils

* update dep version

* fix clippy errors

* update Cargo.lock
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
* Add clap-utils-v3

* update Cargo.lock

* address PR comment: rename crate

* address PR comment: rename to clap-v3-utils

* update dep version

* fix clippy errors

* update Cargo.lock
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
* Add clap-utils-v3

* update Cargo.lock

* address PR comment: rename crate

* address PR comment: rename to clap-v3-utils

* update dep version

* fix clippy errors

* update Cargo.lock
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
* Add clap-utils-v3

* update Cargo.lock

* address PR comment: rename crate

* address PR comment: rename to clap-v3-utils

* update dep version

* fix clippy errors

* update Cargo.lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants