Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Clap3 update: all that depend on clap-utils #23864

Closed
wants to merge 14 commits into from

Conversation

KirillLykov
Copy link
Contributor

Problem

Summary of Changes

Fixes #

@@ -11,7 +11,7 @@ edition = "2021"

[dependencies]
chrono = "0.4"
clap = "2.33.0"
clap = { version = "3.1.5", features = ["cargo"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep here's where we'll need that separate module or crate for clap3, to avoid breaking all downstream users of clap-utils.

If you do this step first, then it's no longer necessary to migrate all clap-utils users in the monorepo to clap3 at the same time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it simplifies life. I've introduced it here -- #24096

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 27, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants