This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clap3 update: all that depend on clap-utils #23864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Mar 23, 2022
| @@ -11,7 +11,7 @@ edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| chrono = "0.4" | |||
| clap = "2.33.0" | |||
| clap = { version = "3.1.5", features = ["cargo"] } | |||
There was a problem hiding this comment.
Yep here's where we'll need that separate module or crate for clap3, to avoid breaking all downstream users of clap-utils.
If you do this step first, then it's no longer necessary to migrate all clap-utils users in the monorepo to clap3 at the same time
There was a problem hiding this comment.
Right, it simplifies life. I've introduced it here -- #24096
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #