-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Clap3 update: all that depend on clap-utils #23864
Conversation
@@ -11,7 +11,7 @@ edition = "2021" | |||
|
|||
[dependencies] | |||
chrono = "0.4" | |||
clap = "2.33.0" | |||
clap = { version = "3.1.5", features = ["cargo"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep here's where we'll need that separate module or crate for clap3, to avoid breaking all downstream users of clap-utils.
If you do this step first, then it's no longer necessary to migrate all clap-utils users in the monorepo to clap3 at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it simplifies life. I've introduced it here -- #24096
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale pull request has been automatically closed. Thank you for your contributions. |
Problem
Summary of Changes
Fixes #