This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add a hidden flag to keygen pubkey subcommand. #31192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag named confirm_key is checked in clap-v3-utils when pubkey is read from a remote ledger. Missing this flag triggers an error. This change adds the flag as a hidden arg to resolve the error.
Codecov Report
@@ Coverage Diff @@
## master #31192 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 729 729
Lines 206304 206304
=========================================
- Hits 168281 168249 -32
- Misses 38023 38055 +32 |
|
fixed by #31194 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The flag named confirm_key is checked in clap-v3-utils when pubkey is read from a remote ledger. Missing this flag triggers an error.
Summary of Changes
This change adds the flag as a hidden arg to resolve the error.