Skip to content

[RFC]: Add/Update package for BooleanArray support (tracking issue) #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
47 tasks done
Jaysukh-409 opened this issue Jun 5, 2024 · 5 comments
Closed
47 tasks done

[RFC]: Add/Update package for BooleanArray support (tracking issue) #2304

Jaysukh-409 opened this issue Jun 5, 2024 · 5 comments
Assignees
@Jaysukh-409
Labels
Tracking Issue Tracking issue.

Comments

@Jaysukh-409
Copy link
Member

Jaysukh-409 commented Jun 5, 2024 •
edited by kgryte
Loading

Description

This RFC proposes add or update all packages that needs to be changed in order to add BooleanArray support to Stdlib. The purpose of this issue is to serve as a tracking issue for update or add packages.

Packages need to added:

  • @stdlib/assert/is-booleanarray
  • @stdlib/strided/base/reinterpret-boolean
  • @stdlib/array/base/assert/is-booleanarray
  • @stdlib/assert/is-same-booleanarray

Packages need to updated:

  • @stdlib/array/dtypes
  • @stdlib/array/dtype
  • @stdlib/array/bool - add methods of BooleanArray and repl.txt
  • @stdlib/array/min-dtype
  • @stdlib/array/ctors
  • @stdlib/array/convert
  • @stdlib/array/convert-same - update tests and benchmarks
  • @stdlib/array/defaults
  • @stdlib/array/docs/types
  • @stdlib/array/empty
  • @stdlib/array/empty-like
  • @stdlib/array/filled
  • @stdlib/array/filled-by
  • @stdlib/array/from-scalar - add tests
  • @stdlib/array/full
  • @stdlib/array/full-like
  • @stdlib/array/mostly-safe-casts
  • @stdlib/array/next-dtype
  • @stdlib/array/pool
  • @stdlib/array/promotion-rules
  • @stdlib/array/safe-casts
  • @stdlib/array/same-kind-casts
  • @stdlib/array/reviver
  • @stdlib/array/to-json
  • @stdlib/array/typed-ctors
  • @stdlib/array/typed-dtypes
  • @stdlib/array/typed
  • @stdlib/array/base/any
  • @stdlib/array/base/assert/has-same-values
  • @stdlib/array/base/count-falsy
  • @stdlib/array/base/count-truthy
  • @stdlib/array/base/count-same-value
  • @stdlib/array/base/count-same-value-zero
  • @stdlib/array/base/cuany
  • @stdlib/array/base/cuevery
  • @stdlib/array/base/every
  • @stdlib/array/base/mskfilter
  • @stdlib/array/base/mskreject
  • @stdlib/array/base/none
  • @stdlib/array/base/take

Related Issues

None

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

@kgryte kgryte added the Tracking Issue Tracking issue. label Jun 5, 2024
This was referenced Jun 6, 2024
Merged
Merged
Merged
Merged
Merged
kgryte added a commit that referenced this issue Jun 6, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support in array/defaults
50e2775 
PR-URL: #2309
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte pushed a commit that referenced this issue Jun 6, 2024
@Jaysukh-409
feat: add boolean dtype support in array/ctors
1510858 
PR-URL: #2308
Ref: #2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 6, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support in array/dtype
26681a0 
PR-URL: #2306
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@kgryte
Copy link
Member

kgryte commented Jun 6, 2024

@Jaysukh-409 Looks like we also need to update various packages in @stdlib/array/base/assert/* to support boolean data types. Should add those packages to the list, as well.

@kgryte
Copy link
Member

kgryte commented Jun 6, 2024

The list should also include:

  • typed-dtypes
  • typed
  • promotion-rules
  • next-dtype
  • safe-casts
  • same-kind-casts
  • from-scalar (tests)
  • pool
  • to-json

This was referenced Jun 10, 2024
Merged
Merged
kgryte added a commit that referenced this issue Jun 10, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support in array/safe-casts
84dcb69 
PR-URL: #2353
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 10, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support in array/same-kind-casts
0be04fe 
PR-URL: #2354
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 11, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/safe-casts
a58e51e 
PR-URL: stdlib-js#2353
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 11, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/same-kind-casts
b1f12bd 
PR-URL: stdlib-js#2354
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte pushed a commit that referenced this issue Jun 12, 2024
@Jaysukh-409
feat: add array/base/assert/is-booleanarray
ce961d9 
PR-URL: #2357
Ref: #2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
This was referenced Jun 12, 2024
Merged
Merged
kgryte pushed a commit that referenced this issue Jun 12, 2024
@Jaysukh-409
feat: add boolean dtype support in array/next-dtype
1b80190 
PR-URL: #2362
Ref: #2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte pushed a commit that referenced this issue Jun 12, 2024
@Jaysukh-409
feat: add sort method to array/bool
d71d044 
PR-URL: #2363
Ref: #2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/defaults
a230e27 
PR-URL: stdlib-js#2309
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @aman-095
feat: add boolean dtype support in array/ctors
238db56 
PR-URL: stdlib-js#2308
Ref: stdlib-js#2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/dtype
64e8148 
PR-URL: stdlib-js#2306
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/safe-casts
fb849e8 
PR-URL: stdlib-js#2353
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @kgryte @aman-095
feat: add boolean dtype support in array/same-kind-casts
9ba7f0e 
PR-URL: stdlib-js#2354
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095 pushed a commit to aman-095/stdlib that referenced this issue Jun 13, 2024
@Jaysukh-409 @aman-095
feat: add array/base/assert/is-booleanarray
2cd54d5 
PR-URL: stdlib-js#2357
Ref: stdlib-js#2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
This was referenced Jun 28, 2024
Merged
Merged
Merged
kgryte added a commit that referenced this issue Jun 29, 2024
@Jaysukh-409 @kgryte
feat: add slice and subarray methods to array/bool
29615af 
PR-URL: #2472
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 29, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/base/count-same-value
fd396b3 
PR-URL: #2473
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 29, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/base/count-same-value-zero
d1ef4ee 
PR-URL: #2474
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 29, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/filled
8a55ea2 
PR-URL: #2471
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jun 29, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/from-scalar
3a3116e 
PR-URL: #2470
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
This was referenced Jul 1, 2024
Merged
Merged
Merged
kgryte added a commit that referenced this issue Jul 1, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/pool
88cece6 
PR-URL: #2486
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jul 1, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/filled-by
37ca4b7 
PR-URL: #2487
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jul 1, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/convert
adb47ab 
PR-URL: #2488
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@Jaysukh-409 Jaysukh-409 mentioned this issue Jul 2, 2024
Merged
1 task
kgryte added a commit that referenced this issue Jul 3, 2024
@Jaysukh-409 @kgryte
feat: add boolean dtype support to array/convert-same
48fd331 
PR-URL: #2494
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@Jaysukh-409 Jaysukh-409 mentioned this issue Jul 4, 2024
Merged
1 task
kgryte added a commit that referenced this issue Jul 5, 2024
@Jaysukh-409 @kgryte
feat: add reduce and reduceRight methods to array/bool
4a6be43 
PR-URL: #2509
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
This was referenced Jul 10, 2024
Merged
Merged
kgryte added a commit that referenced this issue Jul 12, 2024
@Jaysukh-409 @kgryte
feat: add join and toString methods to array/bool
5a66b4b 
PR-URL: #2557
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Jul 13, 2024
@Jaysukh-409 @kgryte
feat!: add boolean dtype support to array/min-dtype
66dce03 
This commit changes the return value when provided a boolean primitive. Previously, the function returned "generic", and now the function returns "bool".

BREAKING CHANGE: return "bool" when provided a boolean

To migrate, users explicitly handle "bool" return values. If "generic" is still desired, users should consolidate accordingly.

PR-URL: #2556
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
@Jaysukh-409 Jaysukh-409 mentioned this issue Jul 13, 2024
Merged
1 task
kgryte pushed a commit that referenced this issue Jul 13, 2024
@Jaysukh-409
feat: add keys, values, and with methods to array/bool
ce3ad9a 
PR-URL: #2590
Ref: #2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
This was referenced Jul 15, 2024
Merged
Merged
kgryte added a commit that referenced this issue Jul 19, 2024
@Jaysukh-409 @kgryte
feat: add copyWithin, entries, forEach to array/bool
cb20ecc 
PR-URL: #2611
Ref: #2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
@kgryte
Copy link
Member

kgryte commented Jul 19, 2024

As all tasks in this tracking issue are now completed, I'll go ahead and close. Thanks, @Jaysukh-409!

@kgryte kgryte closed this as completed Jul 19, 2024
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this issue Aug 21, 2024
@Jaysukh-409 @kgryte @gunjjoshi
feat: add copyWithin, entries, forEach to array/bool
bd2258c 
PR-URL: stdlib-js#2611
Ref: stdlib-js#2304
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaysukh-409 Jaysukh-409

Labels
Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kgryte @stdlib-bot @Jaysukh-409