Skip to content

feat: add sort method to array/bool #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2024
Merged

feat: add sort method to array/bool #2363

merged 2 commits into from
Jun 12, 2024

Conversation

Jaysukh-409
Copy link
Member

Resolves: Subtask of #2304

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array sort method to prototype of BooleanArray

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 12, 2024
kgryte
kgryte requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @Jaysukh-409. Main comment is that the example comparison function should be updated, as a three-way comparison does not make sense for booleans.

kgryte
kgryte approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Jaysukh-409!

@kgryte kgryte merged commit d71d044 into stdlib-js:develop Jun 12, 2024
8 checks passed
@kgryte kgryte deleted the sort branch June 12, 2024 18:13
aman-095 pushed a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
@Jaysukh-409 @aman-095
feat: add sort method to array/bool
5142465 
PR-URL: stdlib-js#2363
Ref: stdlib-js#2304
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaysukh-409 @kgryte