This repository was archived by the owner on May 20, 2020. It is now read-only.
Use JMESPath queries in source tests #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
force-pushed
the
jmespath
branch
2 times, most recently
from
dd21d73 to
742eecf
Compare
|
Ping @steveklabnik |
|
Yeah, sorry; I'll get to this early next week. Still considering JMESPath... |
|
No problem. I'm not completely sold either... but it's powerful and I think it's pretty intuitive. |
|
I am still not 100% sold on this, and it's getting out of date. Let's close it for now and revisit more later. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98.
I made a compromise between needing to quote strings and allowing arbitrary JSON by rolling my own quoting. Slightly weird logic, but I think it's pretty intuitive.
We are also dependent on my jmespath.rs fork currently. I have two outstanding PRs thatimpl Error for jmespath::Errorand an upgrade to serde 1.0.The fixes have been merged upstream and released.