This repository was archived by the owner on May 20, 2020. It is now read-only.
JMESPath Redux #203
Merged
JMESPath Redux #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
approved these changes
Nov 22, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the source tests to use JMESPath instead of JSON Pointer, for lack of a better JSON query language.
This PR differs from #152 in that it doesn't roll its own shell quoting logic. Instead,
@hasoperates on strings and regex, and@matchesis introduced to match JSON values. This PR also introduces@assert, which is shorthand for matching againsttrue.To demonstrate why a more powerful language than JSONPointer is needed, the JSON documentation output from rustdoc is shuffled before the tests are run. This prevents any tests from relying on the order of the arrays, which is impossible with JSONPointer. We could consider doing this for all JSON produced by rustdoc, as it would prevent any frontends from relying on that behavior as well.
cc @steveklabnik @mgattozzi @projektir
Fixes #98.