Skip to content

Remove binary build artifacts #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wieslawsoltes
Copy link
Contributor

@wieslawsoltes wieslawsoltes commented Jan 27, 2020

What does this implement/fix? Explain your changes.

  • Remove binary build artifacts bin and obj folders and contents from Samples\RuntimeUpdates\ path.

also I have noticed some other issues related to samples/solution:

  • Fixed Entities and RuntimeUpdates samples.
  • Removed unused images from Libraries folder.
  • Added XMLOutputTester sample to solution.
  • Moved SVGViewer to Samples solution folder.
  • Removed unnecessary Samples\.gitignore.
  • Added solution Tests folder for test projects.

@mrbean-bremen mrbean-bremen merged commit 95aff13 into svg-net:master Jan 28, 2020
@wieslawsoltes wieslawsoltes deleted the RemoveBinaryBuildArtifacts branch January 28, 2020 07:26
@H1Gdev
Copy link
Contributor

H1Gdev commented Jan 28, 2020

@wieslawsoltes
@mrbean-bremen

Please tell us what the following applications can be used for.

  • Entities
  • SvgSample
  • XMLOutputTester

@H1Gdev
Copy link
Contributor

H1Gdev commented Jan 28, 2020

* XMLOutputTester

I understood this application.

@wieslawsoltes
Copy link
Contributor Author

@wieslawsoltes
@mrbean-bremen

Please tell us what the following applications can be used for.

  • Entities
  • SvgSample
  • XMLOutputTester

This are existing sample apps, I have just added them to solution and fixed build. If they are not helpful I propose to remove them from repo.

@mrbean-bremen
Copy link
Member

These are examples applications, and I agree that they are more visible if added to the solution. I haven't checked the usability of the examples per se - I agree with @wieslawsoltes that they shall be removed if they are obsolete.

@H1Gdev
Copy link
Contributor

H1Gdev commented Jan 28, 2020

@wieslawsoltes
@mrbean-bremen

  • Entities
  • SvgSample

These are just sample codes.
Running it will raise an exception.
Because it is a CLI, you may need to specify arguments.

  • XMLOutputTester

This could be used for code-based testing if modified.

I think that it is better to write description of projects in readme or wiki, if add them to solution.

@mrbean-bremen
Copy link
Member

A description of the samples on a separate documentation page is a good idea! Maybe I will have a look later...

@mrbean-bremen
Copy link
Member

mrbean-bremen commented Jan 28, 2020

I checked the samples. Both are command line tools, but don't need a special command line argument (an example image is provided in both cases).
SvgSample reads an SVG file, changes the style of one of it's elements, and saves it to a png. This works for me.
Entities is supposed to read a file with some unknown entities, providing these entities as a dictionary. This fails, which seems to be a bug - the functionality is probably broken - I'll add an issue for this (added #651).

I still think it is a good idea to have the samples in the solution to improve their visibility.
Concerning the documentation for the samples - I may get at this some time later (currently not up to it, caught a cold), or someone else could have a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants