Fix: #651 'Providing entities in SvgDocument.Open does not work' issue. #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbean-bremen
approved these changes
Jan 29, 2020
Is it possible to run Entities in regression test ? |
I meant not directly, but just read the file from the sample and use the same open call (without saving it back). You can add a test to check the elements that use the elements to have the correct style. |
H1Gdev
force-pushed
the
entities
branch
2 times, most recently
from
a553518 to
f9324e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #651.
Ref. #649 and #90.
What does this implement/fix? Explain your changes.
Any other comments?