Skip to content

Initial Work on W3C Test Compliance #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2014
Merged

Conversation

erdomke
Copy link
Contributor

@erdomke erdomke commented Aug 4, 2014

Sorry for the huge pull request, but I have been working through a number of changes and refactorings to get better support for a number of the W3C tests. I thought that these changes would prove useful in the main branch. Part of the huge commit is including many of the W3C tests in the code so that other developers can work through them as well.

erdomke added 4 commits July 31, 2014 12:51
- Very initial support of CSS stylesheets in the SVG via including the
ExCss and Fizzler libraries
- Bug fixes with path rendering
- Improvements to the API for loading an SVG file
- Adding W3C test cases and a test fixture
- Fixed support for CSS stylesheets (particularly when class names are
referenced)
- Refactoring unit calculations so that percentages and fractions
calculate more accurately
- SvgImage:
- Support PreserveAspectRatio attribute
- Support for referencing svg images
- Refactored text rendering to use the AttributeCollection inheritance
scheme
- Initial attempt at 'ex' unit support
- Added support for system color names
- Changed parsing of entities to support XML entities
- Supporting loading of a svg document directly from a XmlDocument with
requiring serializing the document as a string first.
- ...
@Emasoft
Copy link

Emasoft commented Aug 4, 2014

Wow! I'm looking forward to test it.

@tebjan
Copy link
Contributor

tebjan commented Aug 4, 2014

never be sorry for a huge pull request 👍 i'll integrate it and give it a test run. implementing the official SVG test framework is a big step forward. thank you very much again!

tebjan added a commit that referenced this pull request Aug 4, 2014
Initial Work on W3C Test Compliance
@tebjan tebjan merged commit 535abaf into svg-net:master Aug 4, 2014
@erdomke
Copy link
Contributor Author

erdomke commented Aug 4, 2014

I thought that the project built when I submitted the pull request.
However, if it doesn't, a delete of the defunct "SvgReader" class out of
the c# project should due the trick...

On Mon, Aug 4, 2014 at 10:55 AM, Tebjan Halm notifications@github.com
wrote:

Merged #90 #90.


Reply to this email directly or view it on GitHub
#90 (comment).

@Emasoft
Copy link

Emasoft commented Aug 4, 2014

I've just tried to compile it, and SvgReader class is not the only problem.
There are some added references to the PresentationCore assembly (a WPF component) that give me errors (in example: you are using System.Windows.Media.FontFamily instead of System.Drawing.FontFamily). This is because WPF is not portable and it is not supported by Mono. I think we should make a portable library and avoid using proprietary frameworks like WPF.

@erdomke
Copy link
Contributor Author

erdomke commented Aug 4, 2014

I can see about removing that. It is only referenced by the SvgUnit class
right now. I am using it to try and accurately get the x-height of a font.
WPF provides this quite easily, but I am not quite certain how to handle
it in System.Drawing. Just the same, it should be straightforward to
change.

On Mon, Aug 4, 2014 at 12:17 PM, Emasoft notifications@github.com wrote:

I've just tried to compile it, and SvgReader class is not the only problem.
There are some added references to the PresentationCore assembly (a WPF
component) that give me errors (in example: you are using
System.Windows.Media.FontFamily instead of System.Drawing.FontFamily). This
is because WPF is not portable and it is not supported by Mono. I think we
should make a portable library and avoid using proprietary frameworks like
WPF.


Reply to this email directly or view it on GitHub
#90 (comment).

@Emasoft
Copy link

Emasoft commented Aug 4, 2014

Mmhh.. it seems that the x-height property is not included in System.Drawing. We should calculate that ourselves. But I can't find a documented algorithm to do it.

@erdomke
Copy link
Contributor Author

erdomke commented Aug 4, 2014

My initial thought is just to use 0.5 of the em calculation for the ex
value. While not ideal, I would think that this should be close enough for
most situations. At the very least, it beats not supporting the unit at
all.

On Mon, Aug 4, 2014 at 3:17 PM, Emasoft notifications@github.com wrote:

Mmhh.. it seems that the x-height property is not included in
System.Drawing. We should calculate that ourselves. But I can't find a
documented algorithm to do it.


Reply to this email directly or view it on GitHub
#90 (comment).

mrbean-bremen pushed a commit that referenced this pull request Feb 18, 2021
* Change from XmlTextReader to XmlReader
* related to #90
github-actions bot pushed a commit that referenced this pull request Feb 18, 2021
…CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt Change from XmlTextReader to XmlReader BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt related to #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants