Skip to content

[icu] set CMAKE_POSITION_INDEPENDENT_CODE to YES #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

[icu] set CMAKE_POSITION_INDEPENDENT_CODE to YES #308

merged 1 commit into from
Jun 26, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 25, 2024

No description provided.

@hyp hyp requested review from shahmishal and compnerd as code owners June 25, 2024 19:19
@hyp hyp mentioned this pull request Jun 25, 2024
Merged
compnerd
compnerd approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is required for non-Windows platforms.

@compnerd compnerd mentioned this pull request Jun 25, 2024
Closed
@compnerd
Copy link
Member

I think that I want to run a quick test to ensure that this doesn't regress anything (I don't expect it to) before merging.

@compnerd compnerd merged commit 89540e6 into swiftlang:main Jun 26, 2024
@hyp hyp mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @compnerd