Skip to content

[windows] installer script: add new foundation ICU headers to SDKs #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2024
Merged

[windows] installer script: add new foundation ICU headers to SDKs #321

merged 1 commit into from
Aug 5, 2024

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Aug 2, 2024

This is needed after swiftlang/swift-foundation-icu#39

@hyp hyp requested review from shahmishal and compnerd as code owners August 2, 2024 16:39
@hyp hyp requested review from jmschonfeld and compnerd and removed request for compnerd and shahmishal August 2, 2024 16:40
jmschonfeld
jmschonfeld approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@jmschonfeld jmschonfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Looks like we forgot to update this here when merging ICU. We'll also need to cherry pick this to Swift 6

iCharlesHu
iCharlesHu approved these changes Aug 2, 2024
View reviewed changes
Copy link

@iCharlesHu iCharlesHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@compnerd
Copy link
Member

compnerd commented Aug 2, 2024

Please do a cross-repo test for building the toolchain, but LGTM

@hyp hyp mentioned this pull request Aug 3, 2024
Draft
@hyp hyp merged commit 4105823 into main Aug 5, 2024
@hyp hyp deleted the eng/fix-icu-installer branch August 5, 2024 15:50
@hyp hyp mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@jmschonfeld jmschonfeld jmschonfeld approved these changes

@iCharlesHu iCharlesHu iCharlesHu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyp @compnerd @jmschonfeld @iCharlesHu