[swift 6][windows] installer script: add new foundation ICU headers to SDKs #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyp
changed the title
compnerd
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed after swiftlang/swift-foundation-icu#39
Explanation: After swiftlang/swift-foundation-icu#39 landed in foundation-icu, foundation-icu's modulemap started to depend on new headers from that PR. They need to be installed by the windows SDK installer in order for the modulemap to be valid in the windows toolchain distribution for Swift.
Scope: windows SDK installer
Risk: Low
Testing: toolchain build, and build of windows toolchain in a github workflow
Reviewer: @compnerd
Main branch PR: #321