-
Notifications
You must be signed in to change notification settings - Fork 10.5k
build: enable libxml2 in the toolchain, use llvm-mt
#77862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
46a4bf4
to
73f9a3c
Compare
@swift-ci please test |
Enable support for libxml2 on Windows to allow `llvm-mt` to be usable. This then allows us to use `llvm-mt` as the manifest tool when building for Windows. Remove the then obsoleted workaround of `-D CMAKE_MT=mt`. This reduces the dependency on the MSVC toolchain and paves the path to enabling the use of the manifest tool in SPM.
73f9a3c
to
020d673
Compare
@swift-ci please test |
@swift-ci please smoke test Linux platform |
@swift-ci please smoke test macOS platform |
Steelskin
added a commit
to compnerd/swift-build
that referenced
this pull request
Dec 4, 2024
libxml2 was added as a required dependency downstream in swiftlang/swift#77862. This brings in the libxml2 build to the compilers job to fix the build.
compnerd
pushed a commit
to compnerd/swift-build
that referenced
this pull request
Dec 4, 2024
libxml2 was added as a required dependency downstream in swiftlang/swift#77862. This brings in the libxml2 build to the compilers job to fix the build.
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Feb 4, 2025
Cherrypick commit swiftlang#77862
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
Feb 12, 2025
Cherrypick commit swiftlang#77862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable support for libxml2 on Windows to allow
llvm-mt
to be usable. This then allows us to usellvm-mt
as the manifest tool when building for Windows. Remove the then obsoleted workaround of-D CMAKE_MT=mt
. This reduces the dependency on the MSVC toolchain and paves the path to enabling the use of the manifest tool in SPM.