Skip to content

build: enable libxml2 in the toolchain, use llvm-mt #77862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

compnerd
Copy link
Member

Enable support for libxml2 on Windows to allow llvm-mt to be usable. This then allows us to use llvm-mt as the manifest tool when building for Windows. Remove the then obsoleted workaround of -D CMAKE_MT=mt. This reduces the dependency on the MSVC toolchain and paves the path to enabling the use of the manifest tool in SPM.

@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2024

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Dec 2, 2024

@swift-ci please test

Enable support for libxml2 on Windows to allow `llvm-mt` to be usable.
This then allows us to use `llvm-mt` as the manifest tool when building
for Windows. Remove the then obsoleted workaround of `-D CMAKE_MT=mt`.
This reduces the dependency on the MSVC toolchain and paves the path to
enabling the use of the manifest tool in SPM.
@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2024

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2024

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

compnerd commented Dec 3, 2024

@swift-ci please smoke test macOS platform

@compnerd compnerd enabled auto-merge December 4, 2024 03:03
@compnerd compnerd merged commit ce09887 into swiftlang:main Dec 4, 2024
3 of 5 checks passed
@compnerd compnerd deleted the manifest-xml branch December 4, 2024 05:13
Steelskin added a commit to compnerd/swift-build that referenced this pull request Dec 4, 2024
libxml2 was added as a required dependency downstream in
swiftlang/swift#77862. This brings in the libxml2 build to the compilers
job to fix the build.
compnerd pushed a commit to compnerd/swift-build that referenced this pull request Dec 4, 2024
libxml2 was added as a required dependency downstream in
swiftlang/swift#77862. This brings in the libxml2 build to the compilers
job to fix the build.
hjyamauchi added a commit to hjyamauchi/swift that referenced this pull request Feb 4, 2025
hjyamauchi added a commit to hjyamauchi/swift that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant