Skip to content

Several cherrypicks for the windows build #79143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2025
Merged

Several cherrypicks for the windows build #79143

merged 5 commits into from
Feb 14, 2025

Conversation

hjyamauchi
Copy link
Contributor

No description provided.

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

@hjyamauchi
Copy link
Contributor Author

Explanation: Various Windows build related improvements
Scope: This improves the Windows build.
Issues: No issue
Original PRs: #77986 #76594 #77940 #77862
Risk: The changes are in the Windows build files only and low risk for the non-Windows builds
Testing: The 6.1 CI
Reviewers: @compnerd

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

1 similar comment
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

@hjyamauchi
tools: use LibXml2::LibXml2 to link against
a116fb3 
Adjust the build rules to use the `LibXml2::LibXml2` target rather
than use the explicit include paths and link flags. This allows us to
track additional dependencies (implicit linked libraries) as well as
properly propagate the include paths and library search paths.

Cherrypick commit swiftlang#77848
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Windows platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Linux Platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test macOS Platform

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test Linux Platform

@hjyamauchi hjyamauchi marked this pull request as ready for review February 13, 2025 22:02
@hjyamauchi hjyamauchi requested a review from a team as a code owner February 13, 2025 22:02
@hjyamauchi hjyamauchi requested a review from compnerd February 13, 2025 22:03
@bnbarham
Copy link
Contributor

This also includes #77848. But LGTM 👍

@hjyamauchi hjyamauchi merged commit 7180350 into swiftlang:release/6.1 Feb 14, 2025
5 checks passed
@lxbndr lxbndr mentioned this pull request Feb 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjyamauchi @bnbarham @compnerd