Skip to content

🍒[6.1] tools: use LibXml2::LibXml2 to link against #79373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lxbndr
Copy link
Contributor

@lxbndr lxbndr commented Feb 13, 2025

  • Explanation: (Copied from original PR) Adjust the build rules to use the LibXml2::LibXml2 target rather than use the explicit include paths and link flags. This allows us to track additional dependencies (implicit linked libraries) as well as properly propagate the include paths and library search paths.
  • Scope: Build. Does not impact code.
  • Issues: None
  • Original PRs: tools: use LibXml2::LibXml2 to link against #77848
  • Risk: Low. It either builds or not.
  • Testing: CI should show no fails related to libxml for swift-ide-test target
  • Reviewers: @compnerd

Adjust the build rules to use the `LibXml2::LibXml2` target rather
than use the explicit include paths and link flags. This allows us to
track additional dependencies (implicit linked libraries) as well as
properly propagate the include paths and library search paths.
@lxbndr lxbndr requested a review from a team as a code owner February 13, 2025 22:19
@compnerd
Copy link
Member

@swift-ci please smoke test

@lxbndr
Copy link
Contributor Author

lxbndr commented Feb 15, 2025

#79143 already have this change included.

@lxbndr lxbndr closed this Feb 15, 2025
@lxbndr lxbndr deleted the libxml-target branch February 15, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants