Replacing virtual-modules with a loader for controller.json #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
weaverryan
force-pushed
the
virtual-module-to-loader
branch
2 times, most recently
from
e6760a8 to
f62a939
Compare
|
I've just tested this in a real project along with its sister PR in Encore. It works great! |
tgalopin
reviewed
Jan 22, 2021
src/index.js
Outdated
| // this import is be replaced by the NormalModuleReplacementPlugin | ||
| // to point to the real controllers.json file | ||
| // See create-controllers-module.js | ||
| import symfonyControllers from './webpack/loader!../controllers-placeholder.json'; |
There was a problem hiding this comment.
Is the loader necessary here? If the NormalModuleReplacementPlugin pass before modules, we could have a nicer syntax here, like @symfony/controllers :)
There was a problem hiding this comment.
Per your recommendation, NormalModuleReplacementPlugin is gone in favor of an alias :).
So, the loader IS needed here and I think it's helpful: it helps clarify (for a curious reader) that we are not parsing this as JSON, but doing something trickier.
weaverryan
force-pushed
the
virtual-module-to-loader
branch
from
aa18456 to
04fa4be
Compare
tgalopin
approved these changes
Jan 22, 2021
tgalopin
force-pushed
the
virtual-module-to-loader
branch
from
5f6a96b to
fb5aaf7
Compare
|
Thanks @weaverryan. |
tgalopin
added a commit
that referenced
this pull request
Jan 24, 2021
This PR was merged into the main branch. Discussion ---------- removing old files for the plugin These are extra files I missed in #14 After these are deleted, the error in I added to the readme in #17 will occur if you use the updated version of this lib with an outdated Encore version. Thanks! Commits ------- 017ff71 removing old files for the plugin
weaverryan
added a commit
to symfony/webpack-encore
that referenced
this pull request
Jan 27, 2021
…w loader (weaverryan) This PR was squashed before being merged into the main branch. Discussion ---------- updating stimulus-bridge plugin to work with proposed new loader Partner to symfony/stimulus-bridge#14 * [x] Wait for partner PR to be merged Commits ------- 5640760 updating stimulus-bridge plugin to work with proposed new loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The motivation behind this was a few things:
watchmode and should work just fine with Webpack 5 persistent build caching.This also includes a tricky NormalModuleReplacementPlugin() so that we can continue to handling the parsing of the user's controller.json inside this library (instead of putting the import + loader code in their app).
This will require a partner PR in webpack-encore (symfony/webpack-encore#888). The only line users will need to change in their app is to remove
import '@symfony/autoimport';from theirassets/bootstrap.jsfile.Cheers!