updating stimulus-bridge plugin to work with proposed new loader #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 22, 2021
lib/features.js
Outdated
| @@ -152,7 +152,7 @@ const features = { | |||
| method: 'enableStimulusBridge()', | |||
| packages: [ | |||
| { name: '@symfony/stimulus-bridge' }, | |||
There was a problem hiding this comment.
shouldn't we enforce the version here too (even more than for stimulus) ?
stof
reviewed
Jan 22, 2021
lib/features.js
Outdated
| @@ -152,7 +152,7 @@ const features = { | |||
| method: 'enableStimulusBridge()', | |||
| packages: [ | |||
| { name: '@symfony/stimulus-bridge' }, | |||
| { name: 'stimulus' } | |||
| { name: 'stimulus', enforce_version: true } | |||
There was a problem hiding this comment.
the commit message talks about bumping stimulus version, but that's not what you bumped
There was a problem hiding this comment.
yup - this was a mistake - it should be on the other one - thanks for catching!
2 tasks
tgalopin
added a commit
to symfony/stimulus-bridge
that referenced
this pull request
Jan 22, 2021
…on (weaverryan) This PR was squashed before being merged into the main branch. Discussion ---------- Replacing virtual-modules with a loader for controller.json Hi! The motivation behind this was a few things: 1) the wepback-virtual-modules plugin emits a worrying warning in Webpack 5 and, in general, doesn't seem to be super-actively developed. 2) sokra says that a loader is the correct solution: webpack/webpack#11074 (comment) 3) Since loaders are native/normal, this works well with `watch` mode and should work just fine with Webpack 5 persistent build caching. This also includes a tricky NormalModuleReplacementPlugin() so that we can continue to handling the parsing of the user's controller.json inside this library (instead of putting the import + loader code in their app). This will require a partner PR in webpack-encore (symfony/webpack-encore#888). The only line users will need to change in their app is to remove `import '@symfony/autoimport';` from their `assets/bootstrap.js` file. Cheers! Commits ------- fb5aaf7 Replacing virtual-modules with a loader for controller.json
weaverryan
added a commit
that referenced
this pull request
Jan 23, 2021
…pack 5 persistent caching (weaverryan) This PR was squashed before being merged into the main branch. Discussion ---------- [Webpack 5] Adding new enableBuildCache() method for Webpack 5 persistent caching Hi! This is a very simple feature, but it can also easily be improperly used. It is part of #880. See some comments about it from @Lyrkan from #645: > Things can easily go wrong with persistent caching... even only enabling it for the config file could lead to some issues if not done properly (for instance if the config use values coming from environment variables, which is far from an edge case imo: https://github.com/webpack/changelog-v5/blob/master/guides/persistent-caching.md#version). The trick, for us, is to: A) Make sure we are doing everything as correctly as we can. For example, I assume that WE don't need to include `.babelrc` or `postcss.config.js`, but I actually don't know that for sure. Should we also potentially be adding Encore itself to the build dependencies? B) Good communication in the documentation above the method and in the (eventual) recipe where we include this in the user's webpack.config.js file ## TODO * [ ] 1) Test in a real project to see if we're missing anything (also play with what the valid keys are under `buildDependencies` - other than `config`, this is not documented anywhere). * [x] ~~2) Check into Stimulus: I'm curious if `controllers.json` will need to be added to the build dependencies. I'm also curious if the UX vendor libraries will need to be in the build dependencies, as these do not follow the normal versioning (i.e. their directories in `node_modules/` can change without a change to `yarn.lock` or `package.json`)~~ should be solved by linked changes in #888 Cheers! Commits ------- a592c82 lint 9f117a4 fixing test 7a39654 Adding new enableBuildCache() method for Webpack 5 persistent caching
weaverryan
force-pushed
the
stimulus-bridge-loader
branch
from
57ac055 to
b0bbb5a
Compare
10 tasks
weaverryan
force-pushed
the
stimulus-bridge-loader
branch
4 times, most recently
from
a33cfc4 to
35b11b3
Compare
weaverryan
force-pushed
the
stimulus-bridge-loader
branch
from
35b11b3 to
5640760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partner to symfony/stimulus-bridge#14