[Dropzone] Remove event listeners on disconnect #1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Jul 1, 2024
| @@ -3,10 +3,16 @@ import { Controller } from '@hotwired/stimulus'; | |||
| class default_1 extends Controller { | |||
| connect() { | |||
| this.clear(); | |||
| this.previewClearButtonTarget.addEventListener('click', () => this.clear()); | |||
| this.inputTarget.addEventListener('change', (event) => this.onInputChange(event)); | |||
| this.clear = this.clear.bind(this); | |||
There was a problem hiding this comment.
Isn't it better to bind in initialize stage?
There was a problem hiding this comment.
Ah, yes, didn't think about that!
I'm never binding in connect and always use properties.
class A {
connect() {
someElement.addEventListener('click', this._click);
}
_click = (event) => {
…
};
smnandre
approved these changes
Jul 2, 2024
carsonbot
added
Status: Reviewed
|
@aleho, is the failing translator test related to this change? |
|
@kbond Afaik that's related to the bug introduced by a change to the string component (breaking various parts of Symfony and the UX demos too). (#1950 and symfony/symfony#57612) |
|
Good catch, thanks Alexander. |
|
Thank you @kbond! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events added in controller connect were not removed on disconnect. This would lead to events being triggered twice if a dropzone input is, e.g., moved in the DOM.