Skip to content

[Dropzone] Remove event listeners on disconnect #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Dropzone/assets/dist/controller.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ export default class extends Controller {
readonly previewFilenameTarget: HTMLDivElement;
readonly previewImageTarget: HTMLDivElement;
static targets: string[];
initialize(): void;
connect(): void;
disconnect(): void;
clear(): void;
onInputChange(event: any): void;
_populateImagePreview(file: Blob): void;
Expand Down
12 changes: 10 additions & 2 deletions src/Dropzone/assets/dist/controller.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
import { Controller } from '@hotwired/stimulus';

class default_1 extends Controller {
initialize() {
this.clear = this.clear.bind(this);
this.onInputChange = this.onInputChange.bind(this);
}
connect() {
this.clear();
this.previewClearButtonTarget.addEventListener('click', () => this.clear());
this.inputTarget.addEventListener('change', (event) => this.onInputChange(event));
this.previewClearButtonTarget.addEventListener('click', this.clear);
this.inputTarget.addEventListener('change', this.onInputChange);
this.dispatchEvent('connect');
}
disconnect() {
this.previewClearButtonTarget.removeEventListener('click', this.clear);
this.inputTarget.removeEventListener('change', this.onInputChange);
}
clear() {
this.inputTarget.value = '';
this.inputTarget.style.display = 'block';
Expand Down
14 changes: 12 additions & 2 deletions src/Dropzone/assets/src/controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,29 @@ export default class extends Controller {

static targets = ['input', 'placeholder', 'preview', 'previewClearButton', 'previewFilename', 'previewImage'];

initialize() {
this.clear = this.clear.bind(this);
this.onInputChange = this.onInputChange.bind(this);
}

connect() {
// Reset when connecting to work with Turbolinks
this.clear();

// Clear on click on clear button
this.previewClearButtonTarget.addEventListener('click', () => this.clear());
this.previewClearButtonTarget.addEventListener('click', this.clear);

// Listen on input change and display preview
this.inputTarget.addEventListener('change', (event) => this.onInputChange(event));
this.inputTarget.addEventListener('change', this.onInputChange);

this.dispatchEvent('connect');
}

disconnect() {
this.previewClearButtonTarget.removeEventListener('click', this.clear);
this.inputTarget.removeEventListener('change', this.onInputChange);
}

clear() {
this.inputTarget.value = '';
this.inputTarget.style.display = 'block';
Expand Down
Loading