Skip to content

test: flaky engine/errinj_ddl.test.lua test hangs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avtikhon opened this issue Nov 29, 2020 · 0 comments · Fixed by tarantool/tarantool#11093
Closed

test: flaky engine/errinj_ddl.test.lua test hangs #20

avtikhon opened this issue Nov 29, 2020 · 0 comments · Fixed by tarantool/tarantool#11093
Milestone
wishlist

Comments

@avtikhon
Copy link
Contributor

Tarantool version:
| Tarantool 2.7.0-74-g6ad720d6d
| Target: Linux-x86_64-Debug
| Build options: cmake . -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_BACKTRACE=ON
| Compiler: /usr/bin/cc /usr/bin/c++
| C_FLAGS: -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-gnu-alignof-expression -fno-gnu89-inline -Wno-cast-function-type -Werror
| CXX_FLAGS: -fexceptions -funwind-tables -fno-omit-frame-pointer -fno-stack-protector -fno-common -fopenmp -msse2 -std=c++11 -Wall -Wextra -Wno-strict-aliasing -Wno-char-subscripts -Wno-format-truncation -Wno-invalid-offsetof -Wno-gnu-alignof-expression -Wno-cast-function-type -Werror

OS version:
Linux

Bug description:
https://gitlab.com/tarantool/tarantool/-/jobs/876110769#L4797

results file checksum: 294f6d8da54e492470eb916b862a6dbb

[072] engine/errinj_ddl.test.lua                      vinyl           Test timeout of 170 secs reached	[ fail ]
[072] 
[072] Test failed! Result content mismatch:
[072] --- engine/errinj_ddl.result	Fri Nov 27 06:03:53 2020
[072] +++ /rw_bins/test/var/rejects/engine/errinj_ddl.reject	Fri Nov 27 06:08:14 2020
[072] @@ -64,441 +64,3 @@
[072]  - ok
[072]  ...
[072]  s:format(format) -- must fail
[072] ----
[072] -- error: 'Tuple field 2 type does not match one required by operation: expected string'
[072] -...

Steps to reproduce:

Optional (but very desirable):

  • coredump
  • backtrace
  • netstat
@avtikhon avtikhon self-assigned this Nov 29, 2020
@avtikhon avtikhon transferred this issue from tarantool/tarantool Feb 1, 2021
@kyukhin kyukhin added this to the wishlist milestone Oct 1, 2021
@NickVolynkin NickVolynkin mentioned this issue Mar 15, 2022
Open
sergepetrenko added a commit to sergepetrenko/tarantool that referenced this issue Feb 5, 2025
@sergepetrenko
test: stabilize engine/errinj_ddl test
4e2bdfb 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test
@sergepetrenko sergepetrenko mentioned this issue Feb 5, 2025
Merged
github-actions bot pushed a commit to tarantool/tarantool that referenced this issue Feb 5, 2025
@sergepetrenko @github-actions
test: stabilize engine/errinj_ddl test
319b51f 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
@TarantoolBot TarantoolBot mentioned this issue Feb 5, 2025
Merged
github-actions bot pushed a commit to tarantool/tarantool that referenced this issue Feb 5, 2025
@sergepetrenko @github-actions
test: stabilize engine/errinj_ddl test
15a59c9 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
@TarantoolBot TarantoolBot mentioned this issue Feb 5, 2025
Merged
github-actions bot pushed a commit to tarantool/tarantool that referenced this issue Feb 5, 2025
@sergepetrenko @github-actions
test: stabilize engine/errinj_ddl test
12a73de 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
@TarantoolBot TarantoolBot mentioned this issue Feb 5, 2025
Merged
sergepetrenko added a commit to tarantool/tarantool that referenced this issue Feb 6, 2025
@sergepetrenko
test: stabilize engine/errinj_ddl test
ff55e6b 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
sergepetrenko added a commit to tarantool/tarantool that referenced this issue Feb 6, 2025
@sergepetrenko
test: stabilize engine/errinj_ddl test
7f6b244 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
sergepetrenko added a commit to tarantool/tarantool that referenced this issue Feb 6, 2025
@sergepetrenko
test: stabilize engine/errinj_ddl test
bce1fa1 
The test relied on fibers finishing execution in particular order and
setting/unsetting error injections in time. Of course it was flaky. In
all the 3 flaky cases the fiber unsetting the injection could be
executed before the fiber which sets the injection, and the rest of the
test would run with that injection being set.

Fix this properly and remove the test from the fragile list.

Closes tarantool/tarantool-qa#20

NO_CHANGELOG=flaky test
NO_DOC=flaky test

(cherry picked from commit c86a5e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
wishlist
Development

Successfully merging a pull request may close this issue.

test: stabilize engine/errinj_ddl test sergepetrenko/tarantool
2 participants
@kyukhin @avtikhon