[backport 3.2] test: stabilize engine/errinj_ddl test #11096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test relied on fibers finishing execution in particular order and setting/unsetting error injections in time. Of course it was flaky. In all the 3 flaky cases the fiber unsetting the injection could be executed before the fiber which sets the injection, and the rest of the test would run with that injection being set. Fix this properly and remove the test from the fragile list. Closes tarantool/tarantool-qa#20 NO_CHANGELOG=flaky test NO_DOC=flaky test (cherry picked from commit c86a5e1)
TarantoolBot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is a backport of #11093 to
release/3.2to a future3.2.2release.)The test relied on fibers finishing execution in particular order and setting/unsetting error injections in time. Of course it was flaky. In all the 3 flaky cases the fiber unsetting the injection could be executed before the fiber which sets the injection, and the rest of the test would run with that injection being set.
Fix this properly and remove the test from the fragile list.
Closes tarantool/tarantool-qa#20
NO_CHANGELOG=flaky test
NO_DOC=flaky test