-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_OCCURRENCESTATUS_STANDARD #116
Comments
I feel we need a better example in this test - the one given is confusing. |
@ArthurChapman Better? |
…ON_OCCURRENCESTATUS_STANDARD.
Added to Notes: "This test will fail if there are leading or trailing white space or non-printing characters." |
Changed Source Authority from bdq:sourceAuthority default = "Darwin Core Standard" [https://dwc.tdwg.org/terms/#occurrenceStatus] to bdq:sourceAuthority default = {Darwin Core} {Occurrence status [https://dwc.tdwg.org/terms/#occurrenceStatus] } {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] } |
Amended Source Authority values to align with @chicoreus syntax bdq:sourceAuthority default = {Darwin Core} {Occurrence status [https://dwc.tdwg.org/terms/#occurrenceStatus] } {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] } to bdq:sourceAuthority default = "Darwin Core dwc:occurrenceStatus" {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] } |
Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax: bdq:sourceAuthority default = "Darwin Core dwc:occurrenceStatus" {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] } to bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:occurrenceStatus" [https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]} |
Due to recent discussions, changed Source Authority from bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:occurrenceStatus" [https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]} to bdq:sourceAuthority = "Darwin Core occurrenceStatus" {https://dwc.tdwg.org/list/#dwc_occurrenceStatus} {dwc:occurrenceStatus vocabulary [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]} and Parameter(s) from bdq:sourceAuthority to dwc:occurrenceStatus vocabulary We will need some Notes from @tucotuco |
Updated the Notes from "The reference vocabularies of values for occurrence status need to be developed and published. This test will fail if there is leading or trailing whitespace or there are leading or trailing non-printing characters." to "The original recommended controlled vocabulary for this term consisted of "present" and "absent", which are the only two appropriate terms for a Darwin Core Occurrence. This is reflected in the suggested dwc:occurrenceStatus vocabulary for this test. Other values for dwc:occurrenceStatus should only arise under circumstances that do not refer to an Occurrence. This test will fail if there is leading or trailing whitespace or there are leading or trailing non-printing characters." |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
Updated note from "fail" to more specific "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. " |
For Source Authority API for this and #115, do we want to use dwc:occurrenceStatus vocabulary [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] or dwc:occurrenceStatus vocabulary [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts] ? |
I think there is value in using the GBIF vocabularies whenever they exist and do not conflict with the semantics of Darwin Core, thus, I would opt for dwc:occurrenceStatus vocabulary [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]. |
Changed Source Authority from bdq:sourceAuthority = "Darwin Core occurrenceStatus" {https://dwc.tdwg.org/list/#dwc_occurrenceStatus} {dwc:occurrenceStatus vocabulary [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]} to bdq:sourceAuthority default = "GBIF OccurrenceStatus Vocabulary" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus]} {"dwc:occurrenceStatus vocabulary API" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]} |
@tucotuco I concur. |
How do you want to handle this given the disparity in capitalization between https://dwc.tdwg.org/terms/#dwc:occurrenceStatus and https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts? If we wish to conform to the GBIF vocabulary, we need to change the default and test data, or do a @chicoreus and code to accept either case? I've emailed @timrobertson100 |
For now, changed default to "Present" and modified Example, and added to Notes as per #75. |
Response from Cicilie at GBIF: "May I propose we instead change the English label (label_EN) to lowercase, and you validate your tests with this value?" Considering the email comments on this: Darwin Core states the lower case is the standard.
#75 is ok, as it is just filling bdq:Empty with bdq default - which should be lower case as "present" |
Whatever way this goes, we must respond to Cecilie with some guidance and possibly add this as a use case in the Supplement document regarding vocabularies. |
Change Source Authority from bdq:sourceAuthority default = "GBIF OccurrenceStatus Vocabulary" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus]} {"dwc:occurrenceStatus vocabulary API" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]} to bdq:sourceAuthority default = "Regex present/absent" ["^(present|absent)$"]} {"dwc:occurrenceStatus vocabulary API" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]} and updated the Notes. |
…s, using regex for present/absent, for test tdwg/bdq#116
Removed the GBIF api reference from the source authority as, having incorrect case, it is not of utility for this validation (though it has some utility for the corresponding amendment #115) |
…s, using regex for present/absent, for test tdwg/bdq#116, also updating unit tests to pass for tdwg/bdq#116, tdwg/bdq#75 and tdwg/bdq#115.
The Notes as currently written have two errors. I would also omit the statement "Other values for dwc:occurrenceStatus should only arise under circumstances that do not refer to an Occurrence" because dwc:occurrenceStatus should never refer to anything other than an Occurrence. Here is the recommended fix with the changes highlighted. The second one is hard to see, as it is the comma "following /concepts)". The recommended controlled vocabulary for this term consists of "present" and "absent", which are the only two appropriate terms for a Darwin Core Occurrence. This is reflected in the |
@tucotuco changes applied to the notes. |
The text was updated successfully, but these errors were encountered: