Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_LIFESTAGE_STANDARD #270

Closed
ArthurChapman opened this issue Feb 7, 2024 · 7 comments
Closed

TG2-VALIDATION_LIFESTAGE_STANDARD #270

ArthurChapman opened this issue Feb 7, 2024 · 7 comments
Labels
CODED Conformance OTHER Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 7, 2024

TestField Value
GUID be40d19e-1fe7-42ed-b9d0-961f4cf3eb6a
Label VALIDATION_LIFESTAGE_STANDARD
Description Does the value of dwc:lifeStage occur in bdq:sourceAuthority?
TestType Validation
Darwin Core Class Occurrence
Information Elements ActedUpon dwc:lifeStage
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:lifeStage is bdq:Empty; COMPLIANT if the value of dwc:lifeStage is in the bdq:sourceAuthority; otherwise NOT_COMPLIANT.
Data Quality Dimension Conformance
Term-Actions LIFESTAGE_STANDARD
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF LifeStage Vocabulary" [https://api.gbif.org/v1/vocabularies/LifeStage]} {"dwc:lifeStage vocabulary API" [https://api.gbif.org/v1/vocabularies/LifeStage/concepts]}
Specification Last Updated 2024-02-09
Examples [dwc:lifeStage="Larva": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:lifeStage found in the bdq:sourceAuthority"]
[dwc:lifeStage="Bird mature": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:lifeStages not found in the bdq:sourceAuthority"]
Source TG2
References
Example Implementations (Mechanisms) Kurator/FilteredPush rec_occur_qc Library DOI: 10.5281/zenodo.14968501
Link to Specification Source Code https://github.com/FilteredPush/rec_occur_qc/blob/d742991440f2f5fc6ffc75dfe3b6d2ab5b6826b2/src/main/java/org/filteredpush/qc/metadata/DwCMetadataDQ.java#L2659
Notes This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. This bdq:Supplementary test is not regarded as CORE (cf. bdq:CORE) because of one or more of the reasons: not being widely applicable; not informative; not straightforward to implement or likely to return a high percentage of either bdq:COMPLIANT or bdq:NOT_COMPLIANT results (cf bdq:Response.result). A Supplementary test may be implemented as CORE when a suitable use case exists.
@ArthurChapman ArthurChapman added TG2 Validation OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT VOCABULARY Conformance Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 7, 2024
@Tasilee Tasilee closed this as completed Feb 9, 2024
@chicoreus
Copy link
Collaborator

Removed duplicative text from the notes.

@chicoreus
Copy link
Collaborator

Source authority does not appear to be correctly phrased, references the term as the vocabulary for that term, and a vocabulary as an api endpoint.

@chicoreus chicoreus reopened this Feb 13, 2024
@Tasilee
Copy link
Collaborator

Tasilee commented Feb 13, 2024

As I mentioned elsewhere recently, we had been using the structure of Source Authority for Darwin Core terms based on #104 (but see also #116, #115). The first component refers to the definition of the term (and examples etc) and the second component to a vocabulary of terms or an API if available. This is what @ArthurChapman has used here as a template.

@chicoreus
Copy link
Collaborator

chicoreus commented Feb 13, 2024

@Tasilee yes, you are right, what is throwing me is the reference to an api when we are referring to a vocabulary document (that happens to be returned through an api).

Using #104 as a template:

bdq:sourceAuthority default = "Darwin Core basisOfRecord" {[https://dwc.tdwg.org/terms/#dwc:basisOfRecord]}{dwc:basisOfRecord vocabulary [https://rs.gbif.org/vocabulary/dwc/basis_of_record.xml]}

This one should be:

bdq:sourceAuthority default = "Darwin Core lifeStage [https://dwc.tdwg.org/list/#dwc_lifeStage]} {dwc:lifeStage vocabulary [https://api.gbif.org/v1/vocabularies/LifeStage/concepts]}

with just the vocabulary reference, not the API reference.

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 18, 2024

@chicoreus - agreed and changed.

@chicoreus
Copy link
Collaborator

Updated notes to change "fail" text to explicit "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters."

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Darwin Core lifeStage [https://dwc.tdwg.org/list/#dwc_lifeStage]} {dwc:lifeStage vocabulary" [https://api.gbif.org/v1/vocabularies/LifeStage/concepts]}

to

bdq:sourceAuthority default = "GBIF LifeStage Vocabulary" [https://api.gbif.org/v1/vocabularies/LifeStage]} {"dwc:lifeStage vocabulary API" [https://api.gbif.org/v1/vocabularies/LifeStage/concepts]}

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 26, 2024
…a lightweight implementation of lookup of vocabulary terms and labels from GBIF's vocabulary API. Using this, added an implementation of supplementary test tdwg/bdq#270 VALIDATION_LIFESTAGE_STANDARD.
@chicoreus chicoreus added the CODED label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CODED Conformance OTHER Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY
Projects
None yet
Development

No branches or pull requests

3 participants