Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): should update icon status when formatting the entire block text #10508

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Feb 28, 2025

Closes: BS-2718

Copy link
Contributor Author

fundon commented Feb 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon marked this pull request as ready for review February 28, 2025 07:21
@fundon fundon requested a review from a team as a code owner February 28, 2025 07:21
@graphite-app graphite-app bot requested review from a team February 28, 2025 07:21
@fundon fundon marked this pull request as draft February 28, 2025 07:22
@fundon fundon changed the title fix(editor): should udpate icon statu when formatting the entire block text fix(editor): should update icon status when formatting the entire block text Feb 28, 2025
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 645108e to 87d030a Compare February 28, 2025 07:23
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.44%. Comparing base (98d44d5) to head (916134b).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/affine/widget-toolbar/src/toolbar.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10508   +/-   ##
=======================================
  Coverage   54.43%   54.44%           
=======================================
  Files        2386     2386           
  Lines      109318   109323    +5     
  Branches    18155    18159    +4     
=======================================
+ Hits        59511    59518    +7     
+ Misses      48489    48487    -2     
  Partials     1318     1318           
Flag Coverage Δ
server-test 79.39% <ø> (+0.01%) ⬆️
unittest 30.95% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10508 February 28, 2025 09:28
@fundon fundon force-pushed the graphite-base/10508 branch from 52bfae3 to 45ae61d Compare March 4, 2025 02:58
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 87d030a to 1c17e0c Compare March 4, 2025 02:58
@fundon fundon changed the base branch from graphite-base/10508 to fundon/01_07_add_toolbar_registry_extension March 4, 2025 02:58
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch 2 times, most recently from 3305846 to 2dc284b Compare March 4, 2025 04:40
@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10508 March 4, 2025 06:30
@fundon fundon force-pushed the graphite-base/10508 branch from 45ae61d to 693f7be Compare March 5, 2025 16:29
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 2dc284b to 6d92969 Compare March 5, 2025 16:29
@fundon fundon changed the base branch from graphite-base/10508 to fundon/01_07_add_toolbar_registry_extension March 5, 2025 16:29
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 6d92969 to 9ab8d1a Compare March 5, 2025 16:34
@fundon fundon marked this pull request as ready for review March 5, 2025 16:34
@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10508 March 6, 2025 02:35
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 9ab8d1a to b158c1d Compare March 6, 2025 02:35
@fundon fundon force-pushed the graphite-base/10508 branch from 693f7be to 9835944 Compare March 6, 2025 02:35
@fundon fundon changed the base branch from graphite-base/10508 to fundon/01_07_add_toolbar_registry_extension March 6, 2025 02:35
@Saul-Mirone Saul-Mirone changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10508 March 6, 2025 04:46
@fundon fundon force-pushed the graphite-base/10508 branch from 9835944 to 750c8a4 Compare March 6, 2025 22:35
@fundon fundon force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from b158c1d to 0fa3cb8 Compare March 6, 2025 22:35
@fundon fundon changed the base branch from graphite-base/10508 to canary March 6, 2025 22:35
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Mar 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch from 0fa3cb8 to 916134b Compare March 7, 2025 03:22
@graphite-app graphite-app bot merged commit 916134b into canary Mar 7, 2025
67 checks passed
@graphite-app graphite-app bot deleted the fundon/02_28_should_update_icon_status_when_formatting_the_entire_block_text branch March 7, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants