Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): edgeless element toolbar with new pattern #10511

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Feb 28, 2025

WIP

Copy link
Contributor Author

fundon commented Feb 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 65.91928% with 76 lines in your changes missing coverage. Please review.

Project coverage is 54.19%. Comparing base (7ba1c1b) to head (0e25b53).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...suite/affine/widgets/widget-toolbar/src/toolbar.ts 66.18% 45 Missing and 2 partials ⚠️
...e/affine/blocks/block-embed/src/configs/toolbar.ts 0.00% 10 Missing ⚠️
...cksuite/affine/widgets/widget-toolbar/src/utils.ts 80.48% 4 Missing and 4 partials ⚠️
...ine/shared/src/services/toolbar-service/context.ts 60.00% 4 Missing ⚠️
...ffine/blocks/block-bookmark/src/configs/toolbar.ts 0.00% 3 Missing ⚠️
...ffine/shared/src/services/toolbar-service/flags.ts 0.00% 2 Missing ⚠️
...ine/blocks/block-attachment/src/configs/toolbar.ts 0.00% 1 Missing ⚠️
...mbed/src/embed-synced-doc-block/configs/toolbar.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10511      +/-   ##
==========================================
+ Coverage   54.12%   54.19%   +0.06%     
==========================================
  Files        2413     2427      +14     
  Lines      110157   110257     +100     
  Branches    18263    18272       +9     
==========================================
+ Hits        59622    59750     +128     
+ Misses      49260    49225      -35     
- Partials     1275     1282       +7     
Flag Coverage Δ
server-test 79.32% <ø> (ø)
unittest 30.83% <50.67%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch 2 times, most recently from 0a0abd2 to 491aed4 Compare February 28, 2025 12:19
@fundon fundon force-pushed the fundon/01_07_add_toolbar_registry_extension branch from 7b6f7ac to e4990d9 Compare February 28, 2025 14:28
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch 6 times, most recently from ef34af1 to 2c31ea8 Compare March 3, 2025 02:37
@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10511 March 3, 2025 10:51
@fundon fundon force-pushed the graphite-base/10511 branch from e4990d9 to 45ae61d Compare March 4, 2025 06:22
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch from 2c31ea8 to e44edde Compare March 4, 2025 06:22
@fundon fundon changed the base branch from graphite-base/10511 to fundon/01_07_add_toolbar_registry_extension March 4, 2025 06:22
@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10511 March 4, 2025 06:30
@fundon fundon force-pushed the graphite-base/10511 branch from 45ae61d to 693f7be Compare March 5, 2025 20:14
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch from e44edde to 528d2a8 Compare March 5, 2025 20:14
@fundon fundon changed the base branch from graphite-base/10511 to fundon/01_07_add_toolbar_registry_extension March 5, 2025 20:14
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch 3 times, most recently from 97084a9 to b4d9b0b Compare March 5, 2025 21:37
@fundon fundon changed the base branch from fundon/01_07_add_toolbar_registry_extension to graphite-base/10511 March 6, 2025 02:35
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch 6 times, most recently from 62790aa to 91e62f3 Compare March 8, 2025 09:28
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch 4 times, most recently from 136d2b7 to e885fda Compare March 11, 2025 15:19
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch from e885fda to 3073cf1 Compare March 12, 2025 09:32
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch from 3073cf1 to 0e25b53 Compare March 13, 2025 08:56
@fundon fundon force-pushed the fundon/02_28_refactor_edgeless_element_toolbar branch from 0e25b53 to 04480ad Compare March 13, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant