-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dbatools Koans #140
Add Dbatools Koans #140
Conversation
Pulling from Joel's dbatools again
@shaneis looks much better! Final cleanliness point would just be renaming files to |
🤔 I swear I did that already? Not a problem, I'll rename them 👍 |
I think I have all the changes put in. Should be ready for another review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💖 😊
Solid work, and thanks for putting up with my nitpicking 😁
@potatoqualitee did you want to have a look through before I merge this?
What nitpicking? Not a single negative remark, all positive suggestions. I loved doing this PR! |
Let's merge this before I forget again. 😂 @potatoqualitee at some point it might be interesting to chat about moving module-specific commands to individual modules themselves; would be good to get your thoughts on that if you're interested. Might get a few more written by the community if they're visible / maintained in the main dbatools repo, I'd think. 🤔 Then again, this module would be helpful and/or required for making them work well, so... 🤷 |
All those other dopamine hits are just pretenders!
🎆 🍾
First commit for visibility, guidance, and anything else you can think of @vexx32