Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 286 #681

Closed
wants to merge 17 commits into from
Closed

Fix for issue 286 #681

wants to merge 17 commits into from

Conversation

InAnYan
Copy link
Member

@InAnYan InAnYan commented Mar 22, 2024

Closes #286.

I added a test to DoiFetcherTest for DOI https://doi.org/10.1109/PERCOMW.2015.7133989.

The parsed title of the article should be:

Towards situation-aware adaptive workflows: SitOPT — A general purpose situation-aware workflow management system

But previously it was:

Towards situation-aware adaptive workflows: SitOPT — A general purpose situation-aware workflow management system

In order to make the cleanup, I added some code to the format method of the FieldContentFormatter. (Is that the right file for cleanup?).

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

InAnYan and others added 17 commits March 21, 2024 17:31
* Added support for parsing .lnk files for TeXworks (JabRef#10977)

* Revert "Added support for parsing .lnk files for TeXworks (JabRef#10977)"

This reverts commit f3e2df3.

* Added support for parsing .lnk files for TeXworks (JabRef#10977)

* Added support for parsing .lnk files for TeXworks (JabRef#10977)

* Resolved CheckStyle errors

* Introduce getEmptyIsDefault

* Compilefix

* Update build.gradle and changed empty catch branch

* Used another logger

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
* Change error string

* Change message

* Added more relevant warning

* Change message, add to localization file
# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
@koppor
Copy link
Member

koppor commented Mar 24, 2024

Filed upstring at JabRef#11078, thus closing this one.

@koppor koppor closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cleanup for em dash
4 participants