New examples

[MysaaJava]

What to do

I wanted to use this draft to discuss the examples naming convention: There is currently three naming conventions:
ThingExample, ExampleThing and Thing.
For example, FadeInFadeOut, ExampleFadeInFadeOut and FadeInFadeOutExample.

List of Changes

Added kolibril's examples to the docs. I'm tweaking the code to remove all of the errors during documentation build (especially a bug where ffmpeg complains when using save_last_frame

Motivation

More examples to the docs .... always !

Testing Status

It works. but the documentation still has errors

Acknowledgement

• I have read the Contributing Guidelines

[leotrs]

If something is within the examples section, then it is redundant to add "Example" to the name. So I vote for "Thing". If totally necessary, I vote for "ThingEx", as a shorthand for "ThingExample".

[kolibril13]

@MysaaJava Thanks a lot for putting this up so nicely!! 👍🏼

If something is within the examples section, then it is redundant to add "Example" to the name. So I vote for "Thing"

Yep, I also thing "Thing" would be the prettiest way.
However, sometimes it happened to me that a scene name was already taken by a manim internal class, which will result in errors.
To give an example, if we would name "DotExample" to "Dot", then we would get an error message.
Of course, we can just try to avoid these scenarios in avoiding these forbidden names, however, I feel not completely convinced by that.

I vote for "ThingEx", as a shorthand for "ThingExample".

I can agree on that

[kolibril13]

Just left some comments

[kolibril13]

Thank you for implementing these changes!
Can you click on resolve to the conversations above, so that we know that these changes are implemented?
From my side, I think this is ready to be merged as soon as we have all conversations resolved.
Deciding on how to rename the examples can then be done in a future pr.

[behackl]

I merged master to trigger the RTD build again. Something was weird with it.

[MysaaJava]

I merged master to trigger the RTD build again. Something was weird with it.

It was just something about the logo link that changed (again)

[behackl]

Thank you so much for your work, this is great and improves the documentation by quite a bit again! 💯

I've added a bunch of mostly harmless suggestions (I think all of them concerning code formatting in the examples), please go over them and consider applying them.

And finally: Could you please explain why the changes in scene_file_writer.py were necessary? (This is not really something one would expect from a "more examples" kind of PR, and the file writing stuff is a bit delicate overall. In principle, I am okay with the changes and the tests also still pass, but I'd still like to hear a short explanation from you.)

[behackl]

Also, I am marking this as a PR thats no longer in draft status.

[MysaaJava]

The goal of scene_file_writer modifications was to remove ffmpeg complaining that the partial_movie_file.txt is empty

[behackl]

Thanks for explaining! Then I am also okay with the modifications to scene_file_writer.

[behackl]

Thanks for your efforts! I think this is good to go now.

While looking through the examples you added one last time, I found #610 -- so don't worry if some videos are currently not looking right.

[kolibril13]

Thanks a lot, I know this was a lot of work!
You are a patient and thorough developer, @MysaaJava :)

[leotrs]

Sorry for the delay, and thanks for splitting the PRs.