[PHP] Username checks null default value is empty string

[phiamo]

The php generator checks username and password for null, but default values are empty string ''

openapi-generator/modules/openapi-generator/src/main/resources/php/api.mustache

Line 510 in 1522855

if ($this->config->getUsername() !== null || $this->config->getPassword() !== null) {

openapi-generator/modules/openapi-generator/src/main/resources/php/Configuration.mustache

Line 60 in 1522855

protected $username = '';

When using e.g. an API which supports Bearer and http auth, the bearer Auth header gets replaced by:
Basic Og==

[wing328]

@phiamo thanks for reporting the issue. May I know if you've time to contribute a fix to the issue?

[phiamo]

yes, sure, i am just not sure if it would be better to change default values from '' to null, or checking for empty instead would be better? any suggestions?

[wing328]

I suggest checking for empty as if I remember correctly, that's the approach taken by other clients (e.g. ruby)

To be clear, both username and password must be empty in that condition. (there're use cases in which an empty password is sent to the server)

[phiamo]

Sure, so we leave default values empty strings and check for emptyness as condition... Am Di., 13. Nov. 2018, 10:29 hat William Cheng <notifications@github.com> geschrieben:

…

I suggest checking for empty as if I remember correctly, that's the approach taken by other clients (e.g. ruby) To be clear, both username and password must be empty in that condition. (there're use cases in which an empty password is sent to the server) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1408 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMpu6DGQuwLSorEUT86dAeokPLReuXfks5uupEBgaJpZM4YWWl5> .

[wing328]

Right. Ping me in https://gitter.im if you need any help on the PR. Thanks in advance.

[wing328]

Closed via #1892

@phiamo please give the latest a try when you've time.

[apprme]

Shouldn't this be also applied to the accessToken?

Its default value is empty string as well; when the endpoint supports both bearer and basic auth, first Authorization: Basic ... is added, but then we overwrite it with Authorization: Bearer with empty bearer token.

[wing328]

@apprme right, please kindly submit a PR to fix the accessToken as well if you've time. Thank you.