[PHP] Fix username and password check #1892
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
jfastnacht
force-pushed
the
1408-php-username-empty-check
branch
from
6edbbc7 to
8a8a258
Compare
|
Sometimes the builds are breaking on incomprehensible, random points. Things should be fixed, but this PR goes further than only #1408. I also had to apply the fix in #1863 to make the build work on WIndows, I haven't pushed these changes, since they are already part of the master-branch. The original issue should be solved now, but I'm not sure if it would be a better idea to split up this PR into seperate issues to discuss and PRs to pull. |
Yup, especially weekend as we saw issues downloading dependencies from time to time. Restarting the job (close and reopen the PR) usually fixes the problem |
I didn't knew that you can restart it this way, thanks. |
…ity-test folder. Generated new samples.
…for sample generation. Sample files generated.
…h in the shell script file. Samples generated.
…lways use slash instead of system seperator, since the values will just be used in Markdown files.
jfastnacht
force-pushed
the
1408-php-username-empty-check
branch
from
cc25f5b to
33c23f1
Compare
|
@jfastnacht is this PR ready for review? If yes, I'll remove WIP from the label and the title. |
jfastnacht
changed the title
|
@wing328 tbh, this PR is a mess, because it changes much more than the initial issue states. Not sure if this would be okay anyways, otherwise I'll break it up into seperate issues and PRs. |
|
@jfastnacht I'd a look and I think it's acceptable as your fix is essentially just one line: https://github.com/OpenAPITools/openapi-generator/pull/1892/files#diff-076573ccfdac2ab5af4dc1813e5ccee3R584 |
wing328
changed the title
* master: (758 commits) Add support for free form requests (OpenAPITools#2288) [typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332) [typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324) Fix regex in Python server model code (OpenAPITools#2314) Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330) Add a link to CSDN article (OpenAPITools#2331) [Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318) [PHP] fix bad links in Model docs (OpenAPITools#2316) [java]: fix datatype for non-multipart file request body (OpenAPITools#2271) Removed JFCote from core team (OpenAPITools#2315) [R sample] fix CircleCI error of outdated sample (OpenAPITools#2313) [Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115) Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267) Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268) [PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892) [typescript-fetch] remove namespaces in enums (OpenAPITools#2123) [java-server-msf4j] fix and upgrade (OpenAPITools#2303) fix test script path in CONTRIBUTING.md (OpenAPITools#2290) Dart queryargs (OpenAPITools#2250) add Blueplanet language (OpenAPITools#2184) ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Trying to fix the issue #1408 . Intermediate result, WIP.
Had some problems with the test under Windows 8.1, so it might need a little more than the usual review.
@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon