[typescript-fetch] remove namespaces in enums #2123
Conversation
cassinaooo
changed the title
|
Because of the failing tests I just realized that I messed up with AbstractTypescriptClientCodegen that is used by all typescript clients. Should I modify all typescript templates using namespaces or should I override the Is there any other alternatives? Thank you in advance. |
Please override |
…rator into ts-fetch-namespaces
…riptFetchClientCodegen.postProcessModels
|
I don't know how to solve the Circle CI problem. From what I understand 'UNCOMMITTED CHANGES ERROR' refers to my branch being out of sync with some other one. I tried pulling from upstream master, but it shows 'Already up to date'. Any help is appreciated. Thanks |
|
@willianscfa
this error indicates that some samples need to be re-generated as they do not correspond to newly generated samples anymore. in the meantime, you can simply run https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-angular-petstore-all.sh to re-generate the angular samples and pass CI |
…rator into ts-fetch-namespaces
|
@macjohnny I did a |
|
ok, now the Go and Kotlin samples seem to be out of sync. but it should be possible to merge this PR anyway |
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) |
That has been fixed in the master. |
…rator into ts-fetch-namespaces
Upgrade NoteThe class name is added as a prefix to the enum naming: Before: |
* master: (758 commits) Add support for free form requests (OpenAPITools#2288) [typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332) [typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324) Fix regex in Python server model code (OpenAPITools#2314) Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330) Add a link to CSDN article (OpenAPITools#2331) [Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318) [PHP] fix bad links in Model docs (OpenAPITools#2316) [java]: fix datatype for non-multipart file request body (OpenAPITools#2271) Removed JFCote from core team (OpenAPITools#2315) [R sample] fix CircleCI error of outdated sample (OpenAPITools#2313) [Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115) Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267) Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268) [PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892) [typescript-fetch] remove namespaces in enums (OpenAPITools#2123) [java-server-msf4j] fix and upgrade (OpenAPITools#2303) fix test script path in CONTRIBUTING.md (OpenAPITools#2290) Dart queryargs (OpenAPITools#2250) add Blueplanet language (OpenAPITools#2184) ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Fix behaviour of enums for typescript fetch, removing namespaces according to suggestions made in #1947.
@macjohnny